refactor: Simplify revoking permission in default executor #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922 and
DCNick3
as code owners
dima74
force-pushed
the
diralik/refactor-default-executor-revoke-permissions
branch
from
8defa8a
to
35dfb50
Compare
mversic
previously approved these changes
Nov 16, 2024
s8sato
previously approved these changes
Nov 18, 2024
dima74
force-pushed
the
diralik/refactor-default-executor-revoke-permissions
branch
from
35dfb50
to
de8c7a5
Compare
mversic
approved these changes
Nov 18, 2024
s8sato
reviewed
Nov 18, 2024
s8sato
approved these changes
Nov 19, 2024
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
mversic
force-pushed
the
diralik/refactor-default-executor-revoke-permissions
branch
from
de8c7a5
to
e71898c
Compare
dima74
deleted the
diralik/refactor-default-executor-revoke-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #4087, I noticed that in default executor we have a relatively complex code fragment related to revoking permissions that has been duplicated four times. In #4087, I need it to be duplicated a fifth time, so I think it is worth abstracting it into a separate function.